Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: move inline styles to an external CSS file for CSP #178

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

timmywil
Copy link
Member

Ref jquery/infrastructure-puppet#54

  • Also update the default config-sample.json
  • I switched the <br> elements to self-closing tags while debugging local XML-RPC deployments.

@timmywil timmywil requested a review from mgol October 20, 2024 19:17
@@ -49,11 +49,11 @@ <h3>1.4.5</h3>
<li><a href="https://www.asp.net/ajaxLibrary/CDN.ashx#jQuery_Mobile_Releases_on_the_CDN_4">Microsoft CDN &#8211; jQuery Mobile</a></li>
</ul>

<hr>
<hr />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is HTML; why would we self-close when it has no meaning in HTML?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a preference, but many tags were already self-closing so this at least makes it consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@timmywil timmywil merged commit dd7781c into main Oct 21, 2024
1 check passed
@timmywil timmywil deleted the csp branch October 21, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants