Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border layout sticky example is misleading #4432

Open
3 of 10 tasks
origami-z opened this issue Nov 22, 2024 · 0 comments
Open
3 of 10 tasks

Border layout sticky example is misleading #4432

origami-z opened this issue Nov 22, 2024 · 0 comments
Labels
component: border item component: border layout status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working type: documentation Improvements or additions to documentation

Comments

@origami-z
Copy link
Contributor

Related page(s)

https://www.saltdesignsystem.com/salt/components/border-layout/examples#sticky-positioning

Kind of issue

Broken example

Description

Sticky example is not showing how sticky block is actually doing, therefore teams can't really produce a nice app level set up. e.g. disable the class .saltBorderItem-sticky from devtool, the example doesn't change. It's likely due to the center styling from

className={clsx(styles.borderItem, stickyPositioningStyles.center)}

Using sticky in real life below, all other regions would be scrolled. Applying sticky to west region will make it scroll above north region.
https://stackblitz.com/edit/salt-template-nj8skc?file=App.tsx

The design advice on the documentation is valid, but implementation example needs to be fixed.

Related to SO Question 94322

Browser

  • Chrome
  • Safari
  • Firefox
  • Microsoft Edge

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: bug 🪲 Something isn't working type: documentation Improvements or additions to documentation status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. component: border layout component: border item labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: border item component: border layout status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working type: documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

1 participant