Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart Theme: Categorical color palette re-order #3937

Closed
mark-tate opened this issue Aug 5, 2024 · 17 comments
Closed

Chart Theme: Categorical color palette re-order #3937

mark-tate opened this issue Aug 5, 2024 · 17 comments
Assignees

Comments

@mark-tate
Copy link
Contributor

mark-tate commented Aug 5, 2024

Linked to #3323

Consumers have requested to re-order the categorical color palette to maximize visual contrast between colors in the fixed order.

@mark-tate
Copy link
Contributor Author

Can we start this without knowing the High Charts version we will support ?

@origami-z
Copy link
Contributor

Can we start this without knowing the High Charts version we will support ?

Kind of yes, "Chart theme" is somewhat a generic concept, then we can try to fit as much as possible to Highcharts. Like what we designed data grid, and ag grid theme is a "fit as much as possible" theme.

@mark-tate
Copy link
Contributor Author

Cortado Goal:
Ready for Dev by EOS
Pepper to be stakeholder
Refine ticket (breakout as needed)
Kickoff for charting

@pseys
Copy link
Contributor

pseys commented Aug 12, 2024

While button is on hold I'm picking this up and will refine the description on the Issue to clarify what is required.

@joshwooding
Copy link
Contributor

joshwooding commented Aug 14, 2024

Aug 14 - @pseys caught up with @dplsek. Looking at re-ordering the categorical colors to increase visual contrast between the colors. Currently doing research on how other systems handle this.

@pseys to update the issue description.

Updated end sprint to accommodate for OOO.

@pseys
Copy link
Contributor

pseys commented Aug 15, 2024

  • Proposed re-ordering of category colors defined, based on LLM analysis of difference in hue and brightness of each color and then mapped manually to color contrast scores (final order to be agreed)
  • @dplsek to review revised order with Jonathan and Anh
  • It's assumed reordering the category colors will require a breaking change and will need to be clearly communicated to designers and developers ahead of time.

@joshwooding
Copy link
Contributor

@pseys and @dplsek to break this out into multiple tickets

@joshwooding
Copy link
Contributor

Aug 20 - Shared progress and received feedback/advice that is being reviewed. Another call later to gather feedback.

@dplsek
Copy link

dplsek commented Aug 26, 2024

This ticket has been broken up, re-titled, and the description edited to be specific to the re-ordering of the categorical color palette.

New tickets have been created for the 'broken up' parts previously included in this ticket:
Chart Theme: tokens 4034
Chart Theme: documentation 4035
Chart Theme: design examples 4036

@mark-tate mark-tate changed the title Chart Theme: Figma Data viz tokens + documentation Chart Theme: Categorical Color Palette Aug 28, 2024
@dplsek dplsek changed the title Chart Theme: Categorical Color Palette Chart Theme: Categorical color palette re-order Aug 29, 2024
@mark-tate
Copy link
Contributor Author

Espresso: low priority task as focus is Buttons release, pickup if possible once Buttons work ready for release

@mark-tate
Copy link
Contributor Author

mark-tate commented Sep 16, 2024

Frappe Goal: Figma updated, site docs updated, release announcement

@mark-tate
Copy link
Contributor Author

Design review complete, docs need updating,
how do we release this change and map the colors between old and new mappings

@origami-z
Copy link
Contributor

On re-order, it will definitely be a breaking change.

I'd think - adding separate data viz series using the new order, keeping existing order for Tag, with the potential re-ordering in next breaking change (#1107)

@dplsek
Copy link

dplsek commented Sep 23, 2024

Per @origami-z confirmation that this will definitely be a breaking change, had a meeting with @pseys and @bhoppers2008 and determined the best course of action will be to explain the new order and the rationale via a blog post until we can make the update. This will allow existing consumers to use it they way it currently exists and new consumers to adopt the new proposed order:

NEW (corresponds with option #4)

  1. Plum
  2. Jade
  3. Autumn
  4. Cobalt
  5. Fuchsia
  6. Olive
  7. Indigo
  8. Cider
  9. Forest
  10. Rose
  11. Aqua
  12. Salmon
  13. Ocean
  14. Citrine
  15. Slate
  16. Fur
  17. Lavender
  18. Lime
  19. Violet
  20. Smoke

@origami-z
Copy link
Contributor

origami-z commented Sep 25, 2024

explain the new order and the rationale via a blog post until we can make the update

A blog would be good to explain the rationale, but won't necessarily solve the adoption and transition problem. With the new order, most teams would need to implement sequence similar to our categorical-1/2/3. And so far, we don't know when the next breaking change is.

I would suggest we add a new sequence (maybe with 'data-viz' prefix), so we can point others to it when implementing charts. We can make it clear that it's different order than categorical, which needs to be handled with caution (e.g. when used together with tag). With the new sequence, we may also consider whether 20 or 40 makes sense to be baked in, and/or other discussions (e.g. feedback from Pepper around 500 being not vibrant enough)

(We need to take care of our own mistake, and carry additional work if needed)


(Not in favor, idea only) Throw in another potential (if categorical is mainly driven by Pepper team feedback), can this be handled via Salt vs Salt next difference? Although still being a semi-breaking change.

@mark-tate
Copy link
Contributor Author

Revised Goal: article published by EOS

@mark-tate
Copy link
Contributor Author

Blog written/in-hand and will post this week (internal only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants