Shared config updates #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a source has no shared config of its own and shares a namespace with another source that does have a shared config, then the namespace shared config is used.
🦋 Changeset detectedLatest commit: 5ddf549 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DavieReid
commented
Aug 17, 2023
| namespace | ||
| } | ||
| }; | ||
| config.setData({ applyNamespaceSharedConfig }); |
There was a problem hiding this comment.
the config object is persisted across plugin lifecycle events. So this source is writing to the global config in the hope another source that does have a shared config will apply it.
This is picked up in the afterUpdate event
DavieReid
commented
Aug 17, 2023
joshwooding
approved these changes
Aug 17, 2023
DavieReid
commented
Aug 17, 2023
| .map(key => applyNamespaceSharedConfig?.[key] || []); | ||
|
|
||
| for (const namespaceSharedConfig of namespaceSharedConfigs) { | ||
| if (await mutableFilesystem.promises.exists(namespaceSharedConfig.rootPath)) { |
There was a problem hiding this comment.
This is to guard against the actual write of the shared config.json that is a copy. It might trigger afterUpdate again but not 100% sure
Pull Request Test Coverage Report for Build 5890938994
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have a source that is considered a "child" of another source. Consider:
To a Mosaic site, the product of Source B should work the same as all the other products from Source A. This includes using the shared config of Source A in pages that come from Source B.
This change adds the above feature by allowing a source to apply it's shared config to another source if they share the same namespace
Timeline