-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A mechanism for "showing" implicit attribute values #205
Comments
I'm aiming at compatibility with the PMML specification, not some specific PMML implementation (including my own). Can you point me to a specific PMML markup/construct that is "interpreted" differently by different parties here? Whoever is wrong (SkLearn2PMML, Syncfusion) should fix their implementation. I checked the PMML snippet at your SO question, and actually fail to understand what's missing? There is a top-level |
Workaround: if you're having issues with SkLearn2PMML generated PMML documents, then you might create a small ad hoc Python program that "fixes" the original PMML document in any way you like. Just wrap the |
As I pointed out to Kavin in a comment to his SO answer, I am under the impression that the issue is on the Syncfusion PMML implementation side. Kavin mentioned that Syncfusion implements http://dmg.org/pmml/v4-4/Output.html#xsdType_RESULT-FEATURE but, as far as I understand from reading the XSD, the
So, I don't think there's anything wrong with the sklearn2pmml library. I was just curious to know whether there was a method to add this attribute. Happy to implement a helper function as you suggested. Thank you. |
The Explicit: <OutputField name="decisionFunction" feature="predictedFeature"/> Implicit: <OutputField name="decisionFunction"/> The SkLearn2PMML package switched from explicit to implicit ~6-9 months ago. There's a special purpose In a nutshell, you're asking for its inverse - a Visitor class that would make all implicit attributes explicit. This has been requested before by someone else (can't recall exact issue ID, but there was another PMML engine breaking because of this failing explicit/implicit assumption). TLDR: There might be a use case for implementing such "inverse Visitor class", and making its use configurable via some SkLearn2PMML function flag. |
Comment out these two lines: Then, rebuild the JPMML-Converter project, and replace the old JPMML-Converter library JAR file with this new JAR file in |
Closing as exact duplicate of jpmml/jpmml-converter#13 |
Hi Villu,
I am using Syncfusion PMML package to make prediction from a model saved by sklearn2pmml and have encountered an issue documented in https://stackoverflow.com/questions/59853972/how-to-make-predictions-with-syncfusion-pmml-from-a-neural-network-trained-with
Syncfusion PMML requires the attribute "feature" to be defined not only in the OutputFields of the output layer, but also in the OutputField of the hidden layer. I wonder whether there is a way to programmatically set this attribute in sklearn2pmml.
Thank you,
Davide
The text was updated successfully, but these errors were encountered: