Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button bottom border is displaced (GTK 3.22) #50

Open
trancexpress opened this issue Apr 28, 2018 · 1 comment
Open

Button bottom border is displaced (GTK 3.22) #50

trancexpress opened this issue Apr 28, 2018 · 1 comment

Comments

@trancexpress
Copy link

Especially visible when a button is on focus (e.g. with pressing tab), due to the outline:

GTK 3.22: gtk_322_button_outline_and_border
GTK 3.14: gtk_314_button_outline_and_border

I have reported https://gitlab.gnome.org/GNOME/gtk/issues/206 for the behaviour change, but I think the problem is in the theme itself.

Namely, border.svg defines a 16x16 pixels image. Then it defines a 15x14 pixels rectangle with path width 1 pixel. So the bottom line of the image is an empty line. GTK 3.22 apparently takes this empty line to heart and moves the bottom border up.

Either setting an image size of 16x15 or a border of 15x15 fixes the problem.

I'll be changing the svgs for the iloveeclipse fork (https://github.com/iloveeclipse/clearlooks-phenix/tree/eclipse-patches). However I'm not sure whether the svg should stay at 16x16 size and the border should be 15x15, or if the size should be 16x15 with 15x14 border.

@trancexpress
Copy link
Author

Proposed patch:

borders_patch.txt

Will use this for some time in https://github.com/iloveeclipse/clearlooks-phenix/tree/eclipse-patches, will let you know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant