Replies: 4 comments 1 reply
-
This is not really one that I'm interested in at this point. I don't see why this would add any value for the types of sites that are being developed with the theme - maybe I'm wrong? I'm also very much against including third party code into the base theme as much as possible. It introduces uncontrolled code, negatively impacts performance and just generally adds bloat. The good thing about modules is that they are available for those who want them, and so I prefer to leave it to individuals to make their own choices about when they add value to a particular project. |
Beta Was this translation helpful? Give feedback.
-
I'm against bolting in externally owned stuff as well.... it's best to own the decision of when to adopt change. I wasn't suggesting slurping the module in, so much as implementing the webappmanifest / favicon / (and maybe the service worker stuff ) into the site in an elegant fashion. I pointed out the module because you're already doing more than half the work that this module does in appearance.js The needful remainder is adding some more metadata keys, to be able to handle the pwa component isn't THAT much further a stretch; as it's essentially just including a homegrown js script that's capable of caching content on-device in case of no-network-access. kinda out of scope, yes... but the two components use the same moving parts, and make sense? |
Beta Was this translation helpful? Give feedback.
-
I've raised this question on the hugo discourse forums to try and get some insight into how best to generate a webmanifest resource which the hugo docs assert there's a default output type for; but there's no docs on implementation, nor exemplars ((that I could find)) in the hugo repo... My guess is that there'd be a page bundle that has the needful articulated in the index frontmatter, and the images to resize associated with the pagebundle, and its' output is if that's the case, then I think the hopefully will have some more useful info soon. |
Beta Was this translation helpful? Give feedback.
-
I'm grouping this thread into a single issue to track this feature in one place - see #720. |
Beta Was this translation helpful? Give feedback.
-
Not sure if you've seen this:
https://hugomods.com/en/docs/pwa/
These kids have put together a pretty robust piece of kit that handles a client-side js worker/caching, and the associated metadata to tie it all together...
I don't know that it's a thing to adopt/integrate carte blanche... but it might have some worthwhile bits to integrate.... is this something that's been on the to-do list?
something that you're not excited about at all?
I'm not really for or against it so much as wanting to lay stuff out in a cohesive, well integrated fashion
Beta Was this translation helpful? Give feedback.
All reactions