Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining key[:all] consistency? #2

Open
glennr opened this issue Feb 13, 2014 · 1 comment
Open

Maintaining key[:all] consistency? #2

glennr opened this issue Feb 13, 2014 · 1 comment
Assignees

Comments

@glennr
Copy link

glennr commented Feb 13, 2014

Hi there

First of all good job on creating this plugin.

Just a comment/interesting point I noticed while playing around with TTL's in Redis + Ohm + ohm-expire. If you using Redis' in-built expiry then Ohm's id index (key[:all]) won't be in sync. i.e. We're using Ohm to mark records for expiry, but Ohm knows nothing about when Redis expires them, and thus we cannot maintain the key index at the application level.

Not sure this is an issue worth tackling. I suppose if it's important to someone, they can always rebuild the index. Or one just has to be aware that if they are iterating over the collection of id's in that index, its likely that some of those records have already been expired.

Maybe worth noting the same in the README ?

@joseairosa
Copy link
Owner

That's definitely a good point. Thanks for bringing it up.

I will look into i 👍

@joseairosa joseairosa self-assigned this Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants