Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly measure iteration time in TimePlotter #14

Closed
jorgepiloto opened this issue May 9, 2021 · 2 comments
Closed

Properly measure iteration time in TimePlotter #14

jorgepiloto opened this issue May 9, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jorgepiloto
Copy link
Owner

💻 Feature request: properly time solvers' iterations

After #13 was merged, I did not notice that the time being measured was the whole required by the algorithm to solve the problem. This is not the time per iteration, as also the initial guess and velocity construction vector are also being considered.

Therefore, we must properly return the time per iteration by starting the clock before the iteration begins and stop it once the solution for the independent variable has been found.

It is no possible to do this without modifying solver behavior, so my plan is to add the tpivariable, which means "time per iteration" as an optional return parameter.

@jorgepiloto jorgepiloto added the bug Something isn't working label May 9, 2021
@jorgepiloto jorgepiloto added this to the 0.1 milestone May 9, 2021
@jorgepiloto jorgepiloto self-assigned this May 9, 2021
@jorgepiloto
Copy link
Owner Author

Because a reduction in the measured time is expected (neither initial guess nor velocity vectors assembly considered), we will probably have to update the scale. I think a range between 0 and 500 microseconds is feasible 👍🏽

@jorgepiloto
Copy link
Owner Author

Finally solved! However, a new issue appear while working on this, see #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant