New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark things #801

Open

emartynov opened this issue Jul 7, 2023 · 1 comment

emartynov commented Jul 7, 2023

Hi people,

I appreciate the app. There are a couple of things that I found:

Bookmarking visually is cumbersome on the list:

You don't see the action that bookmarking was accepted
If you bookmark in details - you might not see a bookmark on the list

Bookmarking in detail - the networking result is overriding the user action

screen-20230705-151253.mp4

Collaborator

martinbonnin commented Jul 7, 2023

Thanks!

The bookmark reverting to the old state is because the network request fails. I think there are 2 issues there:

I've seen sometimes where the accessToken was not valid and needed a refresh causing the call to fail, I'm not 100% sure why
More generally, optimistic updates are a bad fit for this pattern. Would be better to use the local database as a source of truth and have a WorkManager retry the call in the background

Don't have much time to dive into this right now but let's aim to rework this for droiconNYC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment