Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / Remove bookmarks on Wear #623

Open
yschimke opened this issue Apr 19, 2023 · 3 comments
Open

Add / Remove bookmarks on Wear #623

yschimke opened this issue Apr 19, 2023 · 3 comments
Labels
wear Wear App functionality

Comments

@yschimke
Copy link
Collaborator

from session screen, or possibly session list (secondary actions?) edit bookmarks

@yschimke yschimke added the wear Wear App functionality label Apr 19, 2023
@oas004
Copy link
Contributor

oas004 commented Nov 4, 2024

On the session list are you thinking to have like a toggle button on each item with the bookmark icon? Or did you have a different design in mind? :) I think now each session is a card. If we are going for from the session details would it be nice to just add a toggle button from horologist(https://github.com/google/horologist/blob/main/compose-material/src/main/java/com/google/android/horologist/compose/material/ToggleButton.kt) at the bottom? Wdyt? :)

@yschimke
Copy link
Collaborator Author

yschimke commented Nov 4, 2024

I'm not sure.

When material3 is ready (#1462), I wanted to add a SwipeToReveal below the Session Card.

https://github.com/joreilly/Confetti/pull/1462/files#diff-e2f98bf7298001f9ef471afe0237dec508d661ea195e0fd98eabba87d6c8286c

@oas004
Copy link
Contributor

oas004 commented Nov 4, 2024

Aha! Okay! Yeah I think adding a swipeToReveal could solve it quite nicely. When looking at it on the M2 version at least, I feel like adding a toggle might cramp things up a bit at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wear Wear App functionality
Projects
None yet
Development

No branches or pull requests

2 participants