Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewdog/reviewdog crit unable to find 'v0.17.2' - use 'latest' #51

Open
jacopocinaark opened this issue Jul 1, 2024 · 4 comments
Open

Comments

@jacopocinaark
Copy link

using the following step in the build workflow:

  - uses: jordemort/action-pyright@v1
    with:
      github_token: ${{ secrets.GITHUB_TOKEN }}
      reporter: github-check
      lib:
      level: warning
      filter_mode: file

we started to get the following error:

image

do someone have any idea about this issue? it started last week trying to build it. last time we did a change we didn't touch this part and it was working fine.

Thanks

@jordemort
Copy link
Owner

I've updated the version of reviewdog, please let me know if this continues to be an issue

@jacopocinaark
Copy link
Author

yes, I got same error...
image

@jordemort
Copy link
Owner

Don't have a lot of time to put into this right now but here's what I've been able to figure out:

I've never actually tested this action on Windows; have you been using it successfully there in the past?

  • If you haven't used this action successfully on Windows before, maybe it never worked there?
  • If you have, the only thing that I can think of is that maybe something has changed in the reviewdog repo ( https://github.com/reviewdog/reviewdog ) in the past 2 weeks? But I can't imagine what would have changed to break it.

I don't have a Windows machine to test things on but a good start to trying to figure this out would be to see if you can get the reviewdog installer script at https://github.com/reviewdog/reviewdog/blob/master/install.sh working on Windows

@jacopocinaark
Copy link
Author

Thanks for the suggestions
I have tried to install in my computer windows and with script was working
image
we haven't changed anything in the build and before was working the step that is failing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants