Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall error is thrown before uninstall preflight is executed #44511

Open
Roeilab opened this issue Nov 23, 2024 · 0 comments
Open

Uninstall error is thrown before uninstall preflight is executed #44511

Roeilab opened this issue Nov 23, 2024 · 0 comments

Comments

@Roeilab
Copy link

Roeilab commented Nov 23, 2024

Steps to reproduce the issue

  • Create an install script in line with Joomla documentation https://manual.joomla.org/docs/building-extensions/install-update/installation/install-process/
  • Add the script to the manifest of your template
  • Add two lines of code to the preflight function (line 1 and 4 below):
    use Joomla\CMS\Log\Log;
    public function preflight(string $type, InstallerAdapter $parent): bool
    {
    Log:add('preflight: ' . $type);
    return true;
    }
  • Install your template, and set it to default (you can do that in postflight function or manually)
  • Uninstall your template

Expected result

  1. The line 'preflight: uninstall' is written to the log file
  2. Joomla throws a warning: Template Uninstall: Can't remove default template

Actual result

  1. Joomla throws a warning: Template Uninstall: Can't remove default template
  2. The line 'preflight: uninstall' is NOT written to the log file

System information (as much as possible)

Additional comments

In the preflight function you should have the opportunity to set the cassiopeia template back to default, and then proceed with uninstall of your custom template. That way you avoid: Template Uninstall: Can't remove default template. That is how it worked on older versions of the install script. But now the uninstall aborts before preflight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants