Skip to content
This repository has been archived by the owner on Mar 17, 2020. It is now read-only.

Creating the Tour Button #1

Open
shivamdiehard opened this issue Jun 4, 2017 · 0 comments
Open

Creating the Tour Button #1

shivamdiehard opened this issue Jun 4, 2017 · 0 comments
Assignees

Comments

@shivamdiehard
Copy link
Contributor

Coding the tour button in JS file.

@shivamdiehard shivamdiehard self-assigned this Jun 4, 2017
zero-24 pushed a commit that referenced this issue Jun 29, 2017
* Fixed callable call in loop termination condition

* Fixed non-optimal regular expression

* Shortened syntax for applied operations

* Don't use strlen() to check if string is empty.

* Reverted preg changes. Look into those later again.

* Replaced call_user_func_array() with call_user_func()

* Merge unset() calls

* Replaced old intval() call with modern typecasting

* Optimize away substr() as index-based access

* Replace some cases of substr() with strpos()

* Replace some stristr() with stripos()

* Replace is_null() with null === ...

* Removed unnecessary ternary operators

* Fix for Juri...

* Revert some changes for ... PHP5.3 compatibility

* Make travis happy ....

* Make codesniffer happy...

* DYC!

* Optimize non-optimal if conditions.

* codsniffer...

* Inline one-time use variables

* Codesniffer...

* Flipped comparisons
`null === ...`  to Joomla Style `... === null`
`null !== ...`  to Joomla Style `... !== null`

* Flipped comparisons
`false !== ...`  to Joomla Style `... !== falsel`

* Fix removal of ternary operator. Forgot inversion.

* More flipping of  comparisons ;)

* Removed another unnecessary set of ternary operators.

* Codesniffer...

* Type-safe comparisons on strings

* More type-safe comparisons

* Changes that occurred during PR discussion

* Remove some unnecessary parentheses

* Removed empty if-group and reversed condition

* Corrections on errors during merge (Conflict resolving)

* Missed one.

* Remove a parenthesis

* Changes according to reviewer's comment

* Revert change because of failure

* Changes according to reviewer's comment
+ a few more changes found last minute

* reversed change, though according to the method's doc that value should have been an integer...

* Hopefully fixed...

* Hopefully fixed...

* Re-apply some changes
zero-24 pushed a commit that referenced this issue Dec 2, 2017
* com_categories

* Update admin-category-modal.min.js

* oops, this is totally useless

* all the rest views that contain this deprecated code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant