Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.14.1 breaks the jQuery val() function on timepickers with useSelect: true #794

Open
jspann3 opened this issue Oct 26, 2023 · 2 comments

Comments

@jspann3
Copy link

jspann3 commented Oct 26, 2023

We recently updated from version 1.14.0 to 1.14.1, and it seems to cause issues with the jQuery("#timepicker_element").val() function. It used to return a string representation of the time, but now it just returns a blank string.

This only happens when useSelect: true is set.

@olaulau
Copy link

olaulau commented Feb 12, 2024

true, very annoying bug !
BTW, thanks for the great job on the plugin.

@ThaNico
Copy link

ThaNico commented Oct 10, 2024

Hi, I'm having another issue on the 1.14.1 where I call setTime when having useSelect set to true and it's not doing anything anymore

@jonthornton I suspect it has to do with this commit : da1007c

image

Rolling back and removing the item.value improves the behavior, I'd do a PR but I have no knowledge of the codebase and this must have been added for a reason ^^
Hope this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants