From 05ee1049892d3035912951fe90fafae60bbe018d Mon Sep 17 00:00:00 2001 From: Jonathan Green Date: Fri, 5 Jan 2024 14:44:48 -0400 Subject: [PATCH] Try adding to a CI build. --- .github/workflows/test-build.yml | 8 -------- docker/ci/test_migrations.sh | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml index d5bdd47bc4..cbc007c0c1 100644 --- a/.github/workflows/test-build.yml +++ b/.github/workflows/test-build.yml @@ -135,14 +135,6 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - - name: Install Poetry - uses: ./.github/actions/poetry - - - name: Poetry install - run: poetry install - env: - POETRY_VIRTUALENVS_CREATE: false - - name: Test migrations run: ./docker/ci/test_migrations.sh diff --git a/docker/ci/test_migrations.sh b/docker/ci/test_migrations.sh index 6582a85329..14de5d03e8 100755 --- a/docker/ci/test_migrations.sh +++ b/docker/ci/test_migrations.sh @@ -1,4 +1,19 @@ -#!/bin/bash -x +#!/bin/bash + +# This script makes sure that our database migrations bring the database up to date +# so that the resulting database is the same as if we had initialized a new instance. +# +# This is done by checking out the an older version of our codebase. The commit when +# the first migration was added and initializing a new instance. Then we check out +# the current version of our codebase and run the migrations. If the database is in +# sync, then the migrations are up to date. If the database is out of sync, then +# a new migration is required. +# +# This test is cannot be added to the normal migration test suite since it requires +# manipulating the git history and checking out older versions of the codebase. +# +# All of the commands in this script are run inside a docker-compose environment. + compose_cmd() { docker --log-level ERROR compose --progress quiet "$@"