Restore MicrometerHttpRequestExecutorTest.waitForContinueGetsPassedTo…

…Super() (micrometer-metrics#5701)
jonatan-ivanov · Nov 25, 2024 · da7eac1 · da7eac1
1 parent 4d2175c
commit da7eac1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/...crometer/core/instrument/binder/httpcomponents/hc5/MicrometerHttpRequestExecutorTest.java b/...crometer/core/instrument/binder/httpcomponents/hc5/MicrometerHttpRequestExecutorTest.java
@@ -37,7 +37,6 @@
 import org.apache.hc.core5.http.io.HttpClientResponseHandler;
 import org.apache.hc.core5.http.io.entity.EntityUtils;
 import org.apache.hc.core5.util.Timeout;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -182,12 +181,12 @@ void routeTaggedIfEnabled(boolean configureObservationRegistry, @WiremockResolve
     }
 
     @Test
-    @Disabled("brittle test using reflection to check internals of third-party code")
     void waitForContinueGetsPassedToSuper() {
         MicrometerHttpRequestExecutor requestExecutor = MicrometerHttpRequestExecutor.builder(registry)
             .waitForContinue(Timeout.ofMilliseconds(1000))
             .build();
-        assertThat(requestExecutor).hasFieldOrPropertyWithValue("waitForContinue", Timeout.ofMilliseconds(1000));
+        assertThat(requestExecutor).extracting("http1Config.waitForContinueTimeout")
+            .isEqualTo(Timeout.ofMilliseconds(1000));
     }
 
     @ParameterizedTest