Eliminate unnecessary null check

jonatan-ivanov · Dec 2, 2024 · 1a2c539 · 1a2c539
1 parent f296b41
commit 1a2c539
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/MeterRegistry.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/MeterRegistry.java
@@ -616,22 +616,18 @@ private Meter getOrCreateMeter(@Nullable DistributionStatisticConfig config,
             BiFunction<Id, /* Nullable Generic */ DistributionStatisticConfig, ? extends Meter> builder, Id originalId,
             Id mappedId, Function<Meter.Id, ? extends Meter> noopBuilder) {
         Meter m = meterMap.get(mappedId);
+        checkAndWarnAboutGaugeDoubleRegistration(m);
 
-        if (m != null) {
-            checkAndWarnAboutGaugeDoubleRegistration(m);
-        }
-        else {
+        if (m == null) {
             if (isClosed()) {
                 return noopBuilder.apply(mappedId);
             }
 
             synchronized (meterMapLock) {
                 m = meterMap.get(mappedId);
+                checkAndWarnAboutGaugeDoubleRegistration(m);
 
-                if (m != null) {
-                    checkAndWarnAboutGaugeDoubleRegistration(m);
-                }
-                else {
+                if (m == null) {
                     if (!accept(mappedId)) {
                         return noopBuilder.apply(mappedId);
                     }