-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
773 UI Show Considered UTXOs before performing transaction #788
773 UI Show Considered UTXOs before performing transaction #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
As far as I am aware, showing the actual used UTXOs is only possible once JoinMarket-Org/joinmarket-clientserver#1713 is merged and release, right? I am not sure this is–in its current form–more confusing to the user. Edit: For non-sweep transactions. |
Yes, you are right. Showing the actual used UTXOs is only possible once JoinMarket-Org/joinmarket-clientserver#1713 is merged and released. I totally agree with your opinion because, as you mentioned earlier, the UTXOs selected in the quick freeze/unfreeze are not actually selected for the transaction; only the |
- Fixed sweep amount - Refactored code (naming) - Removed unnecessary warnings - Added minor improvements - Fixed a few bugs
👍 So we can still include this component and display the UTXOs to the user if it is a sweep transaction!
.. for non-collaborative transactions. Right?
You are not annoying–far from it. Always happy when someone contributes and donates his time. |
yes we can do that
yes
I have included those changes in |
Co-authored-by: Thebora Kompanioni <[email protected]>
…-selected-utxos-before-performing-transaction
Current behaviour: UTXOs are only available for review in case of |
one nitpick: label it from "Selected UTXOs" to "Considered UTXOs" in the Modal, rest is ok from copy side |
* dev(regtest): use polarlightning/bitcoind docker image * dev(regtest): update bitcoin core from v26 to v27
This pull request builds upon the changes introduced in #771
765-ui-implement-utxo-selection-modal
. Please merge #771 before reviewing this PR.This PR fixes #773
Changes:
UTXOs