-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui:Added dropdown for mnemonic phrase input #835
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice improvement
- after entering word 12, the word suggestion is stuck
- one nice addition might be to have enter keystroke select the suggestion when there is only one suggestion
- at recovery selecting the suggestion will not automatically navigate the entry point to the next entry, while it does this at wallet creation?
Hey @MarnixCroes, thanks for pointing that out—I appreciate your feedback. I will take a look into it.
Sure, great suggestion! It would definitely be a nice addition.
Yes, I'm not sure, but I think it's because, at the time of wallet creation, JAM knows the mnemonic, but at the time of import, it doesn't. However, I will take a look and try to add this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 994f6ed
nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice contribution, I tested it on safari macOS
The dropdown remains visible but no longer gets focused when 'tab' is pressed after typing a full word. Now, pressing 'tab' moves directly to the next input element in these cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at recovery when you write the full entry, the suggestion keeps being displayed. Even after the cursor entry is onto the next field.
It goes away when you start typing.
Not a big issue but a bit odd
Screencast.from.10-09-2024.13.31.45.webm
edit: this is the same as #835 (comment) afaict
Yes, if you use
Am I understanding this correctly, @theborakompanioni ? Or is there something I’m missing? |
No, I think @MarnixCroes has a point here. It is good that Edit: Also, tests would be nice for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
27410d9
previous point is fixed #835 (review), this is smoother✅
Another thing: If there are multiple words to select, I need to press tab twice to select the first word. Can that be fixed?
agree that this could be an improvement as well. note that this is only when there is a scrollbar, when there are like just two suggestions then tab will go to the first suggestion at first press
yes
current behaviour: input (ja) -> dropdown appears -> pressed Screencast.from.11-09-24.04.29.41.PM.IST.webm
Got it, but this can be done in a follow-up PR. As we discussed earlier, JAM is going to release a new version soon, so this would be a good addition. But if you need it now, I'm on it. |
Hmm.. it works in Chromium but works differently in Firefox. Here the dropdown itself is in focus after the first tab. But it is not a deal-breaker and can be looked at in a follow-up PR.
Yeeah, that is what most of the time rarely happens when it comes to tests in a follow-up PR 😉 |
Merge as is and open an issue for the follow ups? |
Okay with that. 🙌 |
@MarnixCroes @amitx13 Needs rebasing and some small fixes. I am preparing a patch. |
Fixes: #831
Added recommended word suggestions to the mnemonic phrase input field. The feature aims to improve the usability and accuracy of the mnemonic input process
To Test:
Navigate to
Create new wallet
orImport existing wallet
.