Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid a "direct send" when a jar is "swept" or vice versa #810

Open
editwentyone opened this issue Aug 13, 2024 · 3 comments
Open

Forbid a "direct send" when a jar is "swept" or vice versa #810

editwentyone opened this issue Aug 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@editwentyone
Copy link

editwentyone commented Aug 13, 2024

to not hurt themselves, the user shouldn't be able to sweep a jar AND combine it with a "direct send" aka deactivated coinjoin send.

  • so either its "I want to sweep", the user clicks on sweep, then the toggle under options stays ON but gets "deactivated" to toggle off
  • or its "I want to send a direct send", so the user turns off the toggle under options but then the "sweep" button gets also deactivated on the amount input

it would be also good to have a mouse overlay that's hints why the toggle or sweep button got deactivated:

  • "This function is deactivated because direct send was activated."
  • "This function is deactivated because sweep wallet was activated."

(this routine has nothing todo with the overall wallet "sweep" function from the header menu)

@editwentyone editwentyone added the enhancement New feature or request label Aug 13, 2024
@amitx13
Copy link
Contributor

amitx13 commented Aug 20, 2024

This approach makes sense, but what if the user bypasses the sweep option by manually inputting the full amount in the input field? How should we handle that?

@theborakompanioni
Copy link
Collaborator

I am unsure whether this is a good approach. Of course privacy degrading functions should be discouraged, but outright disabled? It should still be decided by the user what should be done. Jam should make sure the user is aware of what is being done and what the consequences are. Should it?

@editwentyone
Copy link
Author

This approach makes sense, but what if the user bypasses the sweep option by manually inputting the full amount in the input field? How should we handle that?

then the user should get the same reaction as if he would click sweep?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants