-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt absurd_fee_per_kb
setting
#717
Comments
Jam could warn user and if he still agrees dynamically raise |
Yep. Generally "fees and estimates" and how it is best possible to display information to a user so he has even the slightest ideas of what is going on is rather tricky with the API at the moment. It is suboptimal when all possible settings are displayed. The UI should remain simple, but still somehow allow you to adapt most options. Thank God I'm not a designer and @editwentyone has to deal with that and will find a proper solution 🤞 |
Here's my proposal for |
I appreciate the hint @kristapsk 🙏 This could be a viable solution in the web ui too. This, or prompting the user to adapt the |
I was briefly thinking maybe RPC should also adjust absurd fee if manual fee is specified above it, but decided that probably it's not a good idea, better to require clients to use |
Currently,
absurd_fee_per_kb
is hardcoded in Jam and used when validating the fee settings.absurd_fee_per_kb
should be customizable by the user and it should be taken into account when validating fee values.e.g. a user setting tx fee to 349 sats/vbyte with 20% randomization factor will likely have this tx failing without being properly informed exactly why (tx fee > absurd fee).
The text was updated successfully, but these errors were encountered: