Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt absurd_fee_per_kb setting #717

Open
theborakompanioni opened this issue Jan 17, 2024 · 5 comments
Open

feat: adapt absurd_fee_per_kb setting #717

theborakompanioni opened this issue Jan 17, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Jan 17, 2024

Currently, absurd_fee_per_kb is hardcoded in Jam and used when validating the fee settings.
absurd_fee_per_kb should be customizable by the user and it should be taken into account when validating fee values.

e.g. a user setting tx fee to 349 sats/vbyte with 20% randomization factor will likely have this tx failing without being properly informed exactly why (tx fee > absurd fee).

@theborakompanioni theborakompanioni added the enhancement New feature or request label Jan 17, 2024
@kristapsk
Copy link
Contributor

Jam could warn user and if he still agrees dynamically raise absurd_fee_per_kb setting.

@theborakompanioni
Copy link
Collaborator Author

Jam could warn user and if he still agrees dynamically raise absurd_fee_per_kb setting.

Yep. Generally "fees and estimates" and how it is best possible to display information to a user so he has even the slightest ideas of what is going on is rather tricky with the API at the moment. It is suboptimal when all possible settings are displayed. The UI should remain simple, but still somehow allow you to adapt most options. Thank God I'm not a designer and @editwentyone has to deal with that and will find a proper solution 🤞

@kristapsk
Copy link
Contributor

Here's my proposal for sendpayment.py - JoinMarket-Org/joinmarket-clientserver#1636.

@theborakompanioni
Copy link
Collaborator Author

Here's my proposal for sendpayment.py - JoinMarket-Org/joinmarket-clientserver#1636.

I appreciate the hint @kristapsk 🙏 This could be a viable solution in the web ui too. This, or prompting the user to adapt the absurd_fee_per_kb before the transaction.

@kristapsk
Copy link
Contributor

I was briefly thinking maybe RPC should also adjust absurd fee if manual fee is specified above it, but decided that probably it's not a good idea, better to require clients to use configset to override it manually, it's safer.

@theborakompanioni theborakompanioni self-assigned this Jan 27, 2024
@theborakompanioni theborakompanioni added the good first issue Good for newcomers label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants