Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Coin Control #689

Open
kn0wmad opened this issue Oct 29, 2023 · 7 comments
Open

[feat] Coin Control #689

kn0wmad opened this issue Oct 29, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request epic A feature or functionality consisting of multiple building blocks and scenarios
Milestone

Comments

@kn0wmad
Copy link

kn0wmad commented Oct 29, 2023

Describe the solution you'd like
During a non-collaborative send, it would be nice to be able to select a UTXO (and consume it) to spend.

*Note
There is currently a workaround to this where you can freeze all UTXOs except the one you'd like to spend.

@kn0wmad kn0wmad added the enhancement New feature or request label Oct 29, 2023
@kristapsk
Copy link
Contributor

Related - JoinMarket-Org/joinmarket-clientserver#1112 (there is dispute between using UTXOs vs addresses).

@theborakompanioni
Copy link
Collaborator

Ping @editwentyone
Can we think of a nice UI flow during a direct send (non-collaborative send), where a user is able to select specific UTXOs (effectively doing Coin Control)? Maybe a modal is all we need here, e.g. opening on click on the source jar? Or a dedicated button "Coin Control"..?

@kn0wmad
Copy link
Author

kn0wmad commented Oct 30, 2023

To me, when going to the send screen, you would just be presented with the option of collaborative or not. After this selection, you can then decide which UTXOs you'd like to use, with a tick-box for "consume" (to use the entire UTXO without change).

@kn0wmad
Copy link
Author

kn0wmad commented Oct 30, 2023

Related - JoinMarket-Org/joinmarket-clientserver#1112 (there is dispute between using UTXOs vs addresses).

Interesting, although I would still think UTXO control is the more important option as they are the atomic unit in this context, and address re-use maybe ought to be shunned in general, especially when considering privacy. I think my above desired UI/UX could accommodate both, but I would favor UTXOs only, for simplicity.

@kristapsk
Copy link
Contributor

I think my above desired UI/UX could accommodate both, but I would favor UTXOs only, for simplicity.

In UI like Jam this could be actually achieved purely in frontend side - when address reuse has happened, if user selects one of UTXOs sent to that address, just automatically select others related to that address too. And user can override by deselecting them.

@editwentyone
Copy link

editwentyone commented May 7, 2024

@amitx13
Copy link
Contributor

amitx13 commented Jul 15, 2024

[feat] Coin Control #689

  • (ui) Quick freeze/unfreeze UTXOs from selected source Jar
  • (ui) Distinct "Coin Control for Sweeps"
    • Show "Select what UTXOs to send" with a subsequent sweep

Bonus:

@editwentyone editwentyone removed this from the v0.4.0 milestone Oct 22, 2024
@editwentyone editwentyone added this to the v0.5.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic A feature or functionality consisting of multiple building blocks and scenarios
Projects
Status: Todo 📝
Development

No branches or pull requests

5 participants