Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee configuration is not saved #667

Open
f321x opened this issue Sep 24, 2023 · 2 comments
Open

Fee configuration is not saved #667

f321x opened this issue Sep 24, 2023 · 2 comments
Labels
blocked Merging this pull request is blocked until another issue is resolved

Comments

@f321x
Copy link

f321x commented Sep 24, 2023

Expected behavior

Going to settings, setting fee rates for tx and collaborators, doing cj, coming back after a week, doing cj again and it uses the previously configured fees

Actual behavior

Configured fees are reset to their standard values again each time the user tries to do a cj

Steps to reproduce the problem

  1. Set fees
  2. Do cj
  3. Come back later, do cj again -> standard fees

Specifications

  • Version: 0.1.5
  • Platform: Umbrel on Amd64
  • Browser: vanadium & libre wolf

Additional context
Maybe this is intended to not forget about too low tx fees but its somewhat annoying, at least the collaborator fees should be persistent

@f321x f321x added the bug Something isn't working label Sep 24, 2023
@theborakompanioni
Copy link
Collaborator

Hey @f321x, thanks for the report. 🙏

Maybe this is intended to not forget about too low tx fees but its somewhat annoying, at least the collaborator fees should be persistent

Unfortunately, it is not really a bug, but an existing (intentional?) "limitation" of JM.
There is a ticket discussing this: JoinMarket-Org/joinmarket-clientserver#1104
(Want to chime in an "bump" it?)

In the meantime, depending on your install method (i.e. the integration you are using - e.g. does not work on systems using the standalone docker image, like Umbrel/Citadel), you can adapt the joinmarket.cfg yourself, and the settings will survive a node restart.

Only thing we can currently do is to make users aware of the fact.

These settings will be reset to default values when the JoinMarket service restarts, e.g. on a system reboot.

Also.. thought about adding "Adapt fee settings" as distinct step to the "cheatsheet".. do you think this is a good idea, till the ticket mentioned above is resolved? Do you have another idea, how this can be better communicated?

@theborakompanioni theborakompanioni added blocked Merging this pull request is blocked until another issue is resolved and removed bug Something isn't working labels Sep 25, 2023
@f321x
Copy link
Author

f321x commented Sep 25, 2023

Thx for the detailed explanation and quick action.
I think it would be very useful to have a small explanation of this behavior in the fee settings, like in your screenshot. This way the user at least doesn't think it is a bug which makes it overall less confusing.

Personally i wouldn't put it in the cheatsheet as it's a more advanced, optional setting and coinjoining works fine with the standard settings (maybe just a bit more expensive). I guess this would bloat the cheatsheet, making it more confusing for new users that need the cheatsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Merging this pull request is blocked until another issue is resolved
Projects
Status: No status
Development

No branches or pull requests

3 participants