Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display spendable balance on send page #598

Closed
theborakompanioni opened this issue Jan 20, 2023 · 5 comments · Fixed by #600
Closed

Display spendable balance on send page #598

theborakompanioni opened this issue Jan 20, 2023 · 5 comments · Fixed by #600
Assignees
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience

Comments

@theborakompanioni
Copy link
Collaborator

From the chat:

When a jar has less sats than you are trying to spend it let's you attempt the spend and then quietly fails. It took me a few tries to figure out what was going on. Normally this would be obvious, but in the case of jar with the FB it shows the amount of sats including the FB. Leading me to think they were all available to spend.

I think a warning to let you know that you don't have sufficient funds(unlocked/unfrozen) for the proposed spend would fix this.

This has been talked about before, but there is no ticket yet.
It is confusing to show the total balance of a jar, when in fact some UTXOs are frozen or time-locked.
How can this best be displayed and communicated to the user?

@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Jan 20, 2023
@86codyharris
Copy link

I think leaving the total amount(includes frozen&FB utxos) in the Jars view is ok. Would it be possible to just change the amount in the Send>Send From drop down menu to reflect "spendable coins"? This way you shouldn't have payment failures due to trying to spend frozen/FB coins If a user notices a difference in balance from the Jar to the Send From tab they can go back into the Jar and see that it is the frozen/FB coins that have been subtracted.

@theborakompanioni
Copy link
Collaborator Author

Would it be possible to just change the amount in the Send>Send From drop down menu to reflect "spendable coins"?

Yeah, good idea. However, in the current draft of the send page the dropdown menu is replaced by a jar selector.
image

You are right, showing only the spendable balance is already an improvement. Additionally, by adding a way to quickly open a coin control modal (#580) , this might actually not be a horrible UX after all.. :-)

@editwentyone
Copy link

we could adapt this new screen to "spendable amounts" and with a "look inside" you open up a modal or something in this context on the send screen, will think about it

@theborakompanioni
Copy link
Collaborator Author

we could adapt this new screen to "spendable amounts" and with a "look inside" you open up a modal or something in this context on the send screen, will think about it

💯

In #600 the spendable amount is already shown. I like the idea of opening the details view exactly like in the main view. However, it will be done in a follow-up PR, if that is okay with you @editwentyone

@editwentyone
Copy link

sure it is, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants