Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle css with javascript #160

Open
2 tasks
johnwalley opened this issue Feb 8, 2022 · 4 comments · May be fixed by #343
Open
2 tasks

Bundle css with javascript #160

johnwalley opened this issue Feb 8, 2022 · 4 comments · May be fixed by #343
Assignees
@johnwalley
Labels
enhancement New feature or request
Milestone
v2

Comments

@johnwalley
Copy link
Owner

johnwalley commented Feb 8, 2022 •
edited
Loading

Purpose

As a developer I don't want to have to remember to import a separate css file.

Proposal

We can bundle the css by setting the postcss extract option to false. The only thing to check is that the library is still usable when included with a script tag.

Acceptance criteria

  • As a developer I can use the library from a script tag
  • As a developer I do not need to import or include a separate css file
@johnwalley johnwalley added the enhancement New feature or request label Feb 8, 2022
@johnwalley johnwalley self-assigned this Apr 2, 2022
@johnwalley
Copy link
Owner Author

Still interested in implementing this. I wonder if this is a breaking change? I'll start collecting issues with breaking changes together in anticipation of a v2 release.

@johnwalley johnwalley linked a pull request Jun 23, 2022 that will close this issue
Open
@johnwalley johnwalley added this to the v2 milestone Jul 27, 2022
@sergeysova
Copy link
Contributor

If I won't use .css files in my project (prefers CSS-in-JS for example) it will break my setup.

@1pone
Copy link

1pone commented Jan 3, 2023

In my scenario I am using CSS-in-JS as my theme solution, I need to dynamically control the styles to match the theme, and CSS variables don't work well for that.

@johnwalley
Copy link
Owner Author

Hi @sergeysova and @1pone.

Thanks for the feedback. Could you let me know which CSS-in-JS solution (or similar) you're using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnwalley johnwalley

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2
3 participants
@johnwalley @sergeysova @1pone