Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2022-39353 #6

Closed
johnlettman opened this issue Jul 29, 2023 · 0 comments
Closed

Fix CVE-2022-39353 #6

johnlettman opened this issue Jul 29, 2023 · 0 comments

Comments

@johnlettman
Copy link
Owner

Overview

Unfortunately, one of the dependencies includes a vulnerable version of the xmldom package.

There is an open pull request upstream to resolve the issue here: tyrasd/osmtogeojson#138
There is also an open issue referencing the CVE here: tyrasd/osmtogeojson#139

The overpassql-loader package does not use this functionality; however, any project including the loader will pull in the vulnerable code. Therefore, resolving this here is a good move.

CVE description

xmldom parses XML that is not well-formed because it contains multiple top level elements, and adds all root nodes to the childNodes collection of the Document, without reporting any error or throwing.
This breaks the assumption that there is only a single root node in the tree, which led to https://nvd.nist.gov/vuln/detail/CVE-2022-39299 and is a potential issue for dependents.

Temporary Resolution

As a temporary resolution, overpassql-loader should depend on the branch with the vulnerability removed here: https://github.com/tyrasd/osmtogeojson/tree/snyk-fix-65371a4c4920389f7e5127c141088511

Basically:

yarn add "https://github.com/tyrasd/osmtogeojson#snyk-fix-65371a4c4920389f7e5127c141088511"

This serves as advice to others encountering the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant