Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on your warping implementation #54

Open
yataoz opened this issue Aug 1, 2024 · 3 comments
Open

Question on your warping implementation #54

yataoz opened this issue Aug 1, 2024 · 3 comments

Comments

@yataoz
Copy link

yataoz commented Aug 1, 2024

  1. In apply_warping_field function, you add grid to warp_field. However, looks like your warp_field is obtained from WarpGenerator, which already generates warped coordinates instead of offsets. Is this a bug or did I miss something?

  2. What's your definition of predicted head pose in your implementation? Is it from canonical (world) space to camera space or from the reverse? Normally head pose is represented as RT matrix from canonical (world) space to camera space. When doing src -> canonical with backward warping, we should use RT instead of the inversed matrix, right?

  3. It's unclear in the original paper whether they apply the emotion warp filed first or the RT first. From my understanding, the emotion warp field should be in canonical space, so we should only apply emotion deformation in canonical space. This means it should be applied after RT when doing src --> canonical and before RT when doing canonical --> driving. But in your implementation, you always applied after RT regardless of src-->canonical or canonical --> driving.

@johndpope
Copy link
Owner

thanks for bringing this to my attention - I'm investigating.

@johndpope
Copy link
Owner

I create a PR - I'm working on something else - https://github.com/johndpope/IMF
it's latest paper from Microsoft from a few weeks back - it's supposed to supercede denseflow / warp fields.

The EmoPortraits code was supposed to drop last month... it should clear up questions on warping. @JZArray has been outspoken about warp code - but i think the PR may hopefully resolve things.

@johndpope
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants