removed dependency on lodash, removed pnpm-lock.yaml #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeferner
approved these changes
Dec 15, 2023
|
CI failures. We are currently using npm for CI. Perhaps instead of dropping the package-lock we drop the pnpm instead since package-lock is quite a but more familiar to most. |
hulkish
changed the title
Ok made that change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lodash is a huge library.
node-javadoesn't really benefit from or actually need it.I also saw there was a
pnpm-lock.yaml&package-lock.json, so i removedpnpm-lock.yamlas it doesn't make sense, nor is it recommended to support multiple package managers.