From 52de2edff973d66bb0870273b416bcf1e9600bae Mon Sep 17 00:00:00 2001
From: Joe McCarthy <179146301+joe-mccarthy@users.noreply.github.com>
Date: Mon, 14 Oct 2024 18:49:53 +0100
Subject: [PATCH] remove python 3.8 closes #8

---
 .github/workflows/build-test.yml | 2 +-
 CHANGELOG.md                     | 2 ++
 tests/test_api.py                | 4 ++--
 tox.ini                          | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
index 551bcbc..0ec71a9 100644
--- a/.github/workflows/build-test.yml
+++ b/.github/workflows/build-test.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python: ["3.8", "3.9", "3.10", "3.11"]
+        python: ["3.9", "3.10", "3.11", "3.12"]
 
     steps:
       - uses: actions/checkout@v4
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 95d2eb6..efd5133 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+- [#8](https://github.com/joe-mccarthy/harlow-bindicator/issues/8) Remove Python 3.8 as end of life.
+
 ## [2.1.0]
 
 ### Changed
diff --git a/tests/test_api.py b/tests/test_api.py
index 91bf510..8479ec7 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -16,5 +16,5 @@ def test_browser_and_parser_called(mock_browser, mock_parser):
     mock_parser().parse.return_value = ["data"]
 
     assert api.get_data()[0] == "data"
-    mock_browser.get_web_page.called_once()
-    mock_parser.parse.called_once_with("page_source")
+    mock_browser().get_web_page.assert_called_once()
+    mock_parser().parse.assert_called_once_with("page_source")
diff --git a/tox.ini b/tox.ini
index e3b629e..e3d7af7 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py38, py39, py310, py311
+envlist = py39, py310, py311, py312
 isolated_build = True
 
 [testenv]