Remove dependency on xlutils and instead embed a small extract of the library code #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated with (echo '# https://github.com/python-excel/xlutils/raw/master/xlutils/filter.py'; curl -L https://github.com/python-excel/xlutils/raw/master/xlutils/filter.py) > localXlutilsCopy.py
No reason to support python 2 any longer, and besides range has already
been used unconditionally elsewhere in the source, e.g.
for sheet_x in range(workbook.nsheets):
Generated with (echo; echo '# https://github.com/python-excel/xlutils/raw/master/xlutils/copy.py'; curl -L https://github.com/python-excel/xlutils/raw/master/xlutils/copy.py) >> localXlutilsCopy.py
|
Xlutils seems to be a dependency of FreeCAD as well. FreeCAD Dependency Study](https://forum.freecad.org/viewtopic.php?style=4&t=77910) So this embedding I quite don't like. How do they manage this deprecation issue in FreeCAD? |
I understand the post as: FreeCAD sets up a python env using Conda, where It would be nice if InventorLoader dropped dependency on xlutils. I think this is a nice solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue (#62) with depending on an unmaintained/deprecated library.
InventorLoader only uses the
copyfunction from xlutils, and extracting the required code is just 500 lines.