Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in evaluation report #303

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix bug in evaluation report #303

merged 3 commits into from
Oct 16, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Oct 16, 2024

CellsMatchResult can be nil. I think this is the result of default values not being serialized in the protojson.

Update the results manager to include default values when serializing to JSON. This should make SQL queries easier.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for foyle canceled.

Name Link
🔨 Latest commit 8f1ce55
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/670f147ea4986c00086e531a

@jlewi jlewi force-pushed the jlewi/fixevalreport branch from 6f5dca2 to 8f1ce55 Compare October 16, 2024 01:18
@jlewi jlewi marked this pull request as ready for review October 16, 2024 01:19
@jlewi jlewi enabled auto-merge (squash) October 16, 2024 01:19
@jlewi jlewi merged commit 83f7712 into main Oct 16, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/fixevalreport branch October 16, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant