Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some icons not high-DPI ready #238

Open
ofadam opened this issue May 8, 2019 · 3 comments
Open

Some icons not high-DPI ready #238

ofadam opened this issue May 8, 2019 · 3 comments
Labels
bug

Comments

@ofadam
Copy link

ofadam commented May 8, 2019

Some of the buttons are not high-DPI, making them appear pixelated on screens like Apple's MacBook Pro line. Could they be changed to 2x references in the template to make them smooth?

Screen Shot 2019-05-07 at 9 15 08 PM
@jks-prv
Copy link
Owner

jks-prv commented May 10, 2019 •
edited
Loading

Yeah these icons were done a long time ago by hand before I started to use Font Awesome for everything. I don't know what "2x references in the template" means. Maybe you could give me a hint what to do.

@jks-prv jks-prv added the bug label May 10, 2019
@ofadam
Copy link
Author

ofadam commented May 10, 2019

I believe that if you make sure that the source images are 2x the normally required resolution, but then reference it at the required resolution in the code, it should make it high-DPI ready.

@ofadam
Copy link
Author

ofadam commented May 14, 2019

I've adjusted some of the code in a recent pull request. I'll try to continue the work when able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofadam @jks-prv