Error in ItemList->getFirstItem()

[pavel-mironchik]

Method getFirstItem() uses results of method getItems()

$items = $this->getItems(...$types);

and if all ok, then get element with index 0

return $items[0];

Here is the link to this line in code

But method getItems() uses function array_filter(), which preserves the array's keys. So, for example, if we have

ItemList $items [
    0 => type 'Breadcrumb'
    1 => type 'Breadcrumb'
    2 => type 'Product'
]

then after $items->getItems('Product') it will become

ItemList $items [
   2 => type 'Product'
]

and $items[0] will return null.

I suggest to use

public function getFirstItem(...$types)
    {
        $items = array_values($this->getItems(...$types));

or

public function getItems(...$types)
    {
        ...

        return array_values($this->items);

[pavel-mironchik]

It seems that getItems() used as well in method getItemByTypeAndIndex(), where index is valuable. So we can do like this:

public function getFirstItem(...$types)
    {
        $items = array_slice($this->getItems(...$types), 0, 1);