Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for images NOT on docker hub? #5

Open
dlasher opened this issue Mar 14, 2024 · 4 comments
Open

Support for images NOT on docker hub? #5

dlasher opened this issue Mar 14, 2024 · 4 comments

Comments

@dlasher
Copy link

dlasher commented Mar 14, 2024

Trying to extract an image hosted somewhere other than docker hub, and getting:

root@frigate:~# ./docker-image-extract ghcr.io/blakeblackshear/frigate:stable
Getting multi-arch manifest list...
No image digest found. Verify that the image, ref, and platform are valid.

root@frigate:~# ./docker-image-extract ghcr.io/blakeblackshear/frigate:stable-amd64
Getting multi-arch manifest list...
No image digest found. Verify that the image, ref, and platform are valid.

I suspect this is our problem:

# https://docs.docker.com/docker-hub/api/latest/#tag/repositories
manifest_list_url="https://hub.docker.com/v2/repositories/${image}/tags/${ref}"

Would be great to be able to target an image somewhere other than docker hub.

@creshal
Copy link

creshal commented Apr 16, 2024

Yeah, it would be helpful if that was configurable. We would like to use our Gitlab Dependency Proxy to cache images.

@jjlin
Copy link
Owner

jjlin commented Apr 17, 2024

I can probably make some changes for GHCR support at least, but out of curiosity, what are you guys using this script for? I mainly wrote this script for use cases where installing Docker wasn't feasible, but if it is, the real tools are going to be more robust.

@creshal
Copy link

creshal commented Apr 17, 2024

The "real" tools are mostly more bloated. :) We need it for vaultwarden, which recommends using docker-image-extract for when running docker isn't feasible. It's a ridiculous workflow and I'd prefer for vaultwarden to just provide binaries directly, but until that happens, docker-image-extract is faster and easier to implement than adding another containerization layer to our CI.

@dlasher
Copy link
Author

dlasher commented Apr 17, 2024

I wanted to unpack Frigate, so I could build it into an LXC container. It used to be on docker hub (https://hub.docker.com/r/blakeblackshear/frigate) but then moved to https://ghcr.io/blakeblackshear/frigate:stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants