feat(recording): Shows notification when you try to start recording too quick. #15311
Conversation
|
Depends on jitsi/lib-jitsi-meet#2598 |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 This pull request has been sent to HackerOne's PullRequest review team because our automation detected one or more changes with potential security impact. Experts are now being assigned to this review based on relevant expertise and will validate or dismiss any security findings accordingly and post their feedback as comments within this pull request.
Check the status or cancel this secure code review here.
There was a problem hiding this comment.
My only concern is that these changes are not covered by tests. Throttling controls are a type of access control, and should be covered both by unit tests, and by tests that validate the controls are operational in production. See https://cheatsheetseries.owasp.org/cheatsheets/Authorization_Testing_Automation_Cheat_Sheet.html for some tips on this.
Reviewed with ❤️ by PullRequest
No description provided.