Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Improving bot.js for faster responses, and have enhanced error handling #35

Closed
Yash-Vashishth opened this issue Oct 9, 2024 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@Yash-Vashishth
Copy link

Hi @jinx-vi-0 !! Your bot design is amazing !! Though it is concise I think it needs a lot of changes to function in a refined manner.

Here is a summary of the changes I will make- better code organization, enhanced error handling, modular functions for different command handlers, and improved readability.

A long and boring form:-
1.Separate Concerns: Split large functions into smaller, more manageable ones. For instance, the messageCreate event handler could be broken down into separate handlers for each command.
2. Modularization: Create separate files or modules for different functionalities like command handling, utility functions, etc.
3. Cache frequently used data to reduce API calls and improve response times.
4. Optimize the fetchLeetCodeProblems function to handle large datasets efficiently.
5. Follow consistent naming conventions and code formatting for better readability.
6. Using ESLint or Prettier to enforce consistent coding standards.

Copy link

github-actions bot commented Oct 9, 2024

👋 Thank you for raising an issue! We appreciate your effort in helping us improve. Our DDoL team will review it shortly. Stay tuned!

@Yash-Vashishth
Copy link
Author

Also - pls add the hacktoberfest , gssoc-ext , level 3 tag to this code since I will need to commit a lot of changes
Thnks,
Yash Vashishth
(Contributor, GSSoC'24(Extd) and Hacktoberfest)

@rishabh7923
Copy link
Contributor

I am working on point 1 and point 2, soon will do pr

@Yash-Vashishth
Copy link
Author

@rishabh7923 i have raised the issue for this so I believe i have the right to raise the pr for them

And I already have the improved code so no need for you to do pr

@rishabh7923
Copy link
Contributor

I understand that but the issue to which i am assigned already has these things included so i was just letting you know to avoid future conflict. no issues if you still wanna continue

@Yash-Vashishth
Copy link
Author

Hi @jinx-vi-0!! Please atleast please merge this commit to the main branch and add labels. I have made many changes to the code

@jinx-vi-0 jinx-vi-0 added the duplicate This issue or pull request already exists label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants