Skip to content

Commit

Permalink
Upgrade the base image to Ubuntu 24.04 (#24)
Browse files Browse the repository at this point in the history
* Upgrade the base image to Ubuntu 24.04

* fix cosmetics for analysis to be more explicit

* fix sonarcloud action

* Split out lint, test and build from SonarCloud actions

* fix error in build.yml
  • Loading branch information
jimmystewpot authored Sep 17, 2024
1 parent ed78bb3 commit c26e628
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 6 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Unit Test, Lint and Build

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:
schedule:
- cron: "1 1 2 * *"

permissions:
pull-requests: read # allows SonarCloud to decorate PRs with analysis results

jobs:
build_and_test:
name: "Lint Test and Build"
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Test and Build
run: make build

10 changes: 4 additions & 6 deletions .github/workflows/sonarcloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,15 @@ permissions:
pull-requests: read # allows SonarCloud to decorate PRs with analysis results

jobs:
Analysis:
runs-on: ubuntu-22.04
generate_coverage_with_sonarcloud:
name: "Analyse with SonarCloud"
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install Test Dependencies
run: make deps
- name: Run golangci-lint
run: make lint

- name: Run Tests
run: make test
- name: Analyze project with SonarCloud
Expand Down

0 comments on commit c26e628

Please sign in to comment.