From 5b0d62947658f41559396ae3d843ff382ceeb5d8 Mon Sep 17 00:00:00 2001
From: EdJoPaTo
 <rfc-conform-git-commit-email@funny-long-domain-label-everyone-hates-as-it-is-too-long.edjopato.de>
Date: Fri, 29 Oct 2021 15:15:41 +0200
Subject: [PATCH] use bash instead of sh

most often sh is an alias for the default shell.
fish for example is not fully compatible with bash which can result in strange behaviour.
Explicitly stating bash is therefore less problematic on different systems.
---
 README.md             | 18 +++++++++---------
 dependencies_check.sh |  4 ++--
 namespace_checker.sh  |  4 ++--
 start_stream.sh       |  2 +-
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/README.md b/README.md
index 382af25..83a1db0 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@ Bigbluebutton recordings export to `webm` or `mp4` & live broadcasting. This is
 
 The latest Google Chrome stable build should be use.
 
-```sh
+```bash
 curl -sS -o - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add
 echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" > /etc/apt/sources.list.d/google-chrome.list
 apt-get -y update
@@ -24,7 +24,7 @@ apt-get -y install google-chrome-stable
 ```
 
 FFmpeg (if not installed already & have plan for mp4 or RTMP)
-```sh
+```bash
 sudo add-apt-repository ppa:jonathonf/ffmpeg-4
 sudo apt-get update
 sudo apt-get install ffmpeg
@@ -34,7 +34,7 @@ sudo apt-get install ffmpeg
 
 Clone the project first:
 
-```javascript
+```bash
 git clone https://github.com/jibon57/bbb-recorder
 cd bbb-recorder
 npm install --ignore-scripts
@@ -43,7 +43,7 @@ cp .env.example .env
 
 ### Recording export
 
-```sh
+```bash
 node export.js "https://BBB_HOST/playback/presentation/2.0/playback.html?meetingId=MEETING_ID" meeting.webm 10 true
 ```
 
@@ -61,12 +61,12 @@ You can pass 4 args
 
 You can also use `liveJoin.js` to live join meeting as a recorder & perform recording like this:
 
-```sh
+```bash
 node liveJoin.js "https://BBB_HOST/bigbluebutton/api/join?meetingId=MEETING_ID...." liveRecord.webm 0 true
 ```
 Here `0` mean no limit. Recording will auto stop after meeting end or kickout of recorder user. You can also set time limit like this:
 
-```sh
+```bash
 node liveJoin.js "https://BBB_HOST/bigbluebutton/api/join?meetingId=MEETING_ID...." liveRecord.webm 60 true
 ```
 
@@ -78,12 +78,12 @@ Sometime you may want to broadcast meeting via RTMP. To test you can use `ffmpeg
 1) First run websocket server by `node ffmpegServer.js`
 2) Then in another terminal tab
 
-```sh
+```bash
 node liveRTMP.js "https://BBB_HOST/bigbluebutton/api/join?meetingId=MEETING_ID...."
 ```
 You can also set duration otherwise it will close after meeting end or kickout:
 
-```sh
+```bash
 node liveRTMP.js "https://BBB_HOST/bigbluebutton/api/join?meetingId=MEETING_ID...." 20
 ```
 
@@ -91,7 +91,7 @@ Check the process of websocket server, `ffmpeg` should start sending data to RTM
 
 Alternatively, you can stream via a docker container:
 
-```
+```bash
 # copy compose file, update the environment params and the meeting join url
 cp docker-compose.yml.livertmp-stream-example docker-compose.yml
 docker-compose build
diff --git a/dependencies_check.sh b/dependencies_check.sh
index 1588863..360b446 100755
--- a/dependencies_check.sh
+++ b/dependencies_check.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 packages="gconf-service
 libasound2
@@ -69,4 +69,4 @@ if [[ $neededCount -gt 0 ]]; then
   echo "-----------------------------------------------------"
 fi
 
-exit 0
\ No newline at end of file
+exit 0
diff --git a/namespace_checker.sh b/namespace_checker.sh
index 801ab81..fb8d174 100755
--- a/namespace_checker.sh
+++ b/namespace_checker.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 VALUE=$(cat /boot/config-$(uname -r) | grep CONFIG_USER_NS)
 
@@ -18,4 +18,4 @@ else
   echo 'You do not have namespacing in the kernel. You will need to enable the SUID sandbox or upgrade your kernel.'
   echo 'See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md'
   exit 1
-fi
\ No newline at end of file
+fi
diff --git a/start_stream.sh b/start_stream.sh
index 7551675..e9fcc66 100755
--- a/start_stream.sh
+++ b/start_stream.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 # Script to launch a live rtmp streaming session
 # The script populates .env file with environment variables passed by docker-compose.yml