Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Move from TSyringe to Inversify #37

Closed
2 tasks done
jhechtf opened this issue Jun 9, 2023 · 2 comments
Closed
2 tasks done

Move from TSyringe to Inversify #37

jhechtf opened this issue Jun 9, 2023 · 2 comments
Assignees

Comments

@jhechtf
Copy link
Owner

jhechtf commented Jun 9, 2023

Description

TypeScript 5 support comes with the most recent version of Deno. One of the changes is how decorators work, and they require an extra bit in order to be properly typed with the changes that have come from the latest ECMA release.

While a fix has been implemented in Tsyringe back in April of 2023, it is still not released.

Related

This would resolve #27

Exit Criteria

  • Move codebase over to Inversify
  • Ensure documentation is updated to reflect new workings for anyone who may have been using TSyringe based modifications.
@jhechtf jhechtf self-assigned this Jun 9, 2023
@jhechtf
Copy link
Owner Author

jhechtf commented Jun 11, 2023

Might need to find a way to test the branch in a pull request like it would be used from the deno CLI to ensure that it runs correctly. There have been a few errors I found only after a push to Denoland has gone through, and I'm not huge on that.

@jhechtf
Copy link
Owner Author

jhechtf commented Jun 20, 2023

Tsyringe has finally released a version that is workable on TS5, however I will still be pushing this move through at the very least until the final PR stage to see. There are some things about Inversify that solve some (albeit minor) pain points I was having with TSyringe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant