Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer JavaScript compatibility issue. #1

Open
jgreenemi opened this issue Jan 29, 2018 · 0 comments
Open

Internet Explorer JavaScript compatibility issue. #1

jgreenemi opened this issue Jan 29, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jgreenemi
Copy link
Owner

When running the page in Internet Explorer version 11.2007.14393.0, there is an issue where values pulled from the JavaScript dictionary-like object for each resource in ml-assets.js fails with the following error:

SCRIPT1004: Expected ';'
ml-display.js (16,26)

This appears to be because IE does not support loop logic like for (var mlAsset of mlAssets){}. It does appear to support for (var mlAsset in mlAssets){}, but this is not used as is not compatible with Google Chrome. Given that Chrome browser adoption is greater than that of Internet Explorer, I'm not inclined to change this behaviour unless I can find an approach that satisfies both browsers, as well as Firefox and Opera.

@jgreenemi jgreenemi added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant