Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the method getImportAbsolutePath normalize the URL when finding the import's path #42

Closed
wants to merge 3 commits into from
Closed

Changes the method getImportAbsolutePath normalize the URL when finding the import's path #42

wants to merge 3 commits into from

Conversation

mAiNiNfEcTiOn
Copy link

@mAiNiNfEcTiOn mAiNiNfEcTiOn commented Jun 28, 2019 •
edited
Loading

What does this PR do:

  • Changes the method getImportAbsolutePath to pass the url normalized to the findImportedPath to solve paths' issues on Windows coming from importers

Where should the reviewer start:

  • Diffs

Fixes #41

Changes the method getImportAbsolutePath to pass the url normaliz…
b96cb55 
…ed to the `findImportedPath` to solve paths' issues on Windows coming from importers
@mAiNiNfEcTiOn mAiNiNfEcTiOn changed the title Changes the method getImportAbsolutePath to pass the url normaliz… Changes the method getImportAbsolutePath normalize the URL when finding the import's path Jun 28, 2019
@mAiNiNfEcTiOn
Copy link
Author

@jgranstrom now that the tests are failing, a little bit of context:

  • The dependency foundation-sites has changed its structure and files since version 6.5.0. If I lock the version to ~6.4.3, the tests failing related to normalize.scss (foundation-variables tests) will be fixed.

  • If I lock the version of the peer dependency node-sass to ^3.8.0 (ergo not supporting 4) the tests failing related to Invalid CSS (in the map-keys tests) will go away.

Would you like me to lock those dependencies' versions or would you prefer to fix the unit tests?
Although the latter would seem the most interesting approach, it is also the most complex, since it requires changes on test logic for variables and also requires to check "if node-sass's version is X assert one thing, if it's Y assert another".

@mAiNiNfEcTiOn
Copy link
Author

Oh, and if you run the build on your master today it'll have the same problem (so, the change I did does not cause it 😉 )

@jgranstrom jgranstrom closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When calling the findImportedPath the url should be normalized to prevent issues on Windows
2 participants
@mAiNiNfEcTiOn @jgranstrom