Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every conversion output ends with a linefeed #34

Open
pavel-zdenek opened this issue Aug 5, 2015 · 1 comment
Open

Every conversion output ends with a linefeed #34

pavel-zdenek opened this issue Aug 5, 2015 · 1 comment

Comments

@pavel-zdenek
Copy link

We are using quite distant fork of this project, but the issue originates here. Every fork in the chain retains it unquestioned, so i dare to ask at the source.

strcat(p, "\n\n");

Having every markdown_to_* retval tailed with line feed is a bug in our books. If the line is removed, 9 of 22 tests fails in various strange ways. Our use cases are quite simple and fall in the 13 passing tests, but we would like to contribute an universally working improvement. No linefeed in, no linefeed out. Is it possible? It might be an indispensable parser preprocessing hack in which case we will give up and just remove the linefeeds on our end.

@jgm
Copy link
Owner

jgm commented Aug 6, 2015

I'm not active maintaining this project any more (I'm focusing my efforts now on jgm/cmark), so you'll have to attack this at some downstream point.

+++ Pavel Zdeněk [Aug 05 15 09:58 ]:

We are using quite distant fork of this project, but the issue
originates here. Every fork in the chain retains it unquestioned, so i
dare to ask at the source.
[1]https://github.com/jgm/peg-markdown/blob/2dfff24fb877bca11efe2cf9131
6f4abd3ef016a/markdown_lib.c#L47
Having every markdown_to_* retval tailed with line feed is a bug in our
books. If the line is removed, 9 of 22 tests fails in various strange
ways. Our use cases are quite simple and fall in the 13 passing tests,
but we would like to contribute an universally working improvement. No
linefeed in, no linefeed out. Is it possible?


Reply to this email directly or [2]view it on GitHub.

References

  1. strcat(p, "\n\n");
  2. Every conversion output ends with a linefeed #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants