Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List highlighted annotations for open editors #21

Open
warrentyy opened this issue May 13, 2021 · 6 comments · Fixed by #32
Open

List highlighted annotations for open editors #21

warrentyy opened this issue May 13, 2021 · 6 comments · Fixed by #32
Labels
help wanted Extra attention is needed

Comments

@warrentyy
Copy link

Low priority, but might save some people from thinking the extension is broken or digging through settings like I did.

Right now, the List highlighted annotations only works when you have a folder open (and probably a workspace but I haven't tried that). When you are working on individual files in one or more editors, the command returns 0 results. In lieu of this, it might be beneficial for the response message to mention this caveat. Currently, it simply returns: "No results" even though the file I'm looking at clearly has highlights.

Hope that makes sense, aside from that minor thing, loving this extension!

@alkatar21
Copy link
Collaborator

I think that is why I was just about to create an issue.
I opened VSCode on a folder with scripts that have multiple TODOs and ran the List highlighted annotations command, but even though the files themselves have highlights, the command returns 0 results.

I am not sure I understand what is meant here, when the command works? Do I need a subfolder or am I misunderstanding and my case should work normally?

I am new to VSCode, but I am trying to get the TODO view of PyCharm back.

@jgclark jgclark added the help wanted Extra attention is needed label Sep 2, 2021
@jgclark
Copy link
Owner

jgclark commented Sep 2, 2021

I'm sorry but I don't know JS well, nor am I the original author of the plugin. (I am the maintainer of a new fork of this, as the original author abandoned it.). So I welcome PRs to improve the code or documentation on this point. (I have never used this feature, so I'm not sure quite what it should be doing.)

@alkatar21
Copy link
Collaborator

I had a thinking error, it works for me now, but that has nothing to do with this issue.
I will make an extra issue for this. But this would also be useful.

@jgclark
Copy link
Owner

jgclark commented Sep 3, 2021

I have updated the documentation to reflect this.

@alkatar21
Copy link
Collaborator

The PR was not intended to close the issue, since the actual problem has not been fixed.

@jgclark
Copy link
Owner

jgclark commented Sep 6, 2021

Sorry, thought I was closing the PR.

@jgclark jgclark reopened this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants