Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration failure with VSCode-Remote #19

Open
Tiogshi opened this issue Mar 29, 2021 · 3 comments
Open

Integration failure with VSCode-Remote #19

Tiogshi opened this issue Mar 29, 2021 · 3 comments

Comments

@Tiogshi
Copy link

Tiogshi commented Mar 29, 2021

When using in a vscode remote session, the output from VSCode-TODO-Highlight doesn't seem to format well for making the links (successfully) clickable. Representative screenshot attached:

image

I suspect the actual problem is VS Code expects filename[:line[:column]] format when a full URL path is used, instead of the filename#line format which is possibly supported only when using a local filesystem path? But that's just a theory, which needs to be tested.

Suggestion: try outputting the filename[:line[:column]] format instead, see if it works in both local and vscode-remote contexts.

@jgclark
Copy link
Owner

jgclark commented Apr 5, 2021

Have you tried both settings of the todohighlight.toggleURI setting?
If you have, then I suspect the issue resides in the showOutputChannel function in util.js, but as I don't know JavaScript, I'm not confident to make changes. (I took on maintenance; I'm not the original author.) PRs are welcome, if you do know JavaScript, @Tiogshi.

@Tiogshi
Copy link
Author

Tiogshi commented Apr 6, 2021

Tried it out.

In a local workspace (Windows), I get URLs of the form file:///(drive)(path). When these end in #(line), they go to the correct place (the option you mentioned, unchecked). When they end in :line[:col], clicking them results in file-not-found as above.

In a remote workspace (Linux), I get URLs of the form vscode-remote://ssh-remote+(connection-name)(path). When they end in :line[:col], they go to the correct place (the option you mentioned, checked). When they end in #line, clicking them results in file-not-found as above.

I'm guessing this exact problem is why that option was added to the plugin? But I alternate between local and remote workspaces on basically a daily basis.

Took a quick glance at the TODOHighlight source. Looks like microsoft/vscode#586 is still open 5+ years later. I'll take a gander for a more consistent API to detect the true platform to use in a vscode-remote situation... but in the meantime, looks like the only plausible solution is for me to save that option (todohighlight.toggleURI) as a Workspace setting on those workspaces which I use strictly remotely.

(EDIT: clarified platforms in question, above)

@jgclark
Copy link
Owner

jgclark commented Apr 6, 2021

That's good work. Thanks for being willing to try to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants