Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature_request]: hugo module management #147

Open
deining opened this issue Mar 19, 2023 · 1 comment · May be fixed by #149
Open

[feature_request]: hugo module management #147

deining opened this issue Mar 19, 2023 · 1 comment · May be fixed by #149
Labels
feature New feature or request

Comments

@deining
Copy link
Contributor

deining commented Mar 19, 2023

What is missing in the project?

I just got aware of your theme, great work!
I realized that your theme

  • is not a hugo module yet.
  • is based on bulma framework, which is pulled in as git submodule.

Solution?

My proposal is to transform the theme to a hugo module. Then you can pull in bulma framework as hugo module, which makes update of this dependency even easier.
A while ago, I authored a pull request that did exactly that for the hugo-fresh theme (which is based on bulma too). The theme author accepted my PR and we got it merged. Let me know if you are interested in receiving a similar PR for your shadocs theme. I'm happy to step in and assist you here!
@jgazeau
Copy link
Owner

jgazeau commented Mar 19, 2023

Hi @deining ,

Indeed I never took time to look at that, but it seems more easier for both contributors and users...could be very useful.
I will be glad to add it in the theme, so don't hesitate to push a PR .
Thanks a lot 😊

@jgazeau jgazeau changed the title [feature_request]: [feature_request]: hugo module management Mar 19, 2023
@jgazeau jgazeau added the feature New feature or request label Mar 19, 2023
This was referenced Mar 22, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: conversion of theme to hugo module (#147) deining/shadocs
2 participants
@deining @jgazeau