Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix the tag #25

Open
magnetic-pi opened this issue Dec 8, 2013 · 0 comments
Open

Please fix the tag #25

magnetic-pi opened this issue Dec 8, 2013 · 0 comments

Comments

@magnetic-pi
Copy link

Hi there,

I was trying to use pip to install your project based off the tag. I tried the following:

pip install -e git+https://github.com/jgarzik/[email protected]#egg=bitcoinrpc

This kept failing because your actual tag is v0.3-33-ge484743:

pip install -e git+https://github.com/jgarzik/[email protected]#egg=bitcoinrpc

If you type, "git tag" the tag will appear correctly, however if you run "git describe" on your repo you will see the actual tag. The tag gets into this state if you, cut a tag, and merge something into the existing, after the tag has been set. For more information please see:

https://www.kernel.org/pub/software/scm/git/docs/git-describe.html

I am a release engineer, and I encounter this every release week. :( I added this to my requriements.txt, so if you make any changes, the tag will change to 34 and thus it will break my "pip install -r requirements" command. I'm very big on sharing knowledge, so I hope you don't find this offensive. I just recently found out about this myself.

At work I am trying to get everyone to follow semantic versioning:

http://semver.org/

Perhaps you could just add a 1 at the end of your tag so it would be: 0.3.1

I love the project! Thanks so much for the great work.

Cheers,
Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant