Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop guard to prevent running child process #36

Open
jfrimmel opened this issue Mar 17, 2021 · 0 comments
Open

Add drop guard to prevent running child process #36

jfrimmel opened this issue Mar 17, 2021 · 0 comments
Assignees
@jfrimmel

Comments

@jfrimmel
Copy link
Owner

As noted in this line:

cargo-valgrind/src/main.rs

Line 99 in 2da5213

// TODO: use drop guard, that waits on child in order to prevent printing to stdout of the child

the program needs a drop guard for cases, when the main program dies (e.g. it was killed with Ctrl+C). The current behavior is, that the program exits, but the valgrind child-process remains alive and prints to the standard output of the main process.
@jfrimmel jfrimmel self-assigned this Mar 17, 2021
jfrimmel added a commit that referenced this issue Sep 20, 2024
@jfrimmel
Add test for behavior if tool is killed mid-run
40d3951 
This is the codified version of #36, just with a SIGKILL instead of the
mentioned SIGING (or SIGTERM). It is unclear, if the tool could even be-
have sane with SIGKILL, but this is the only thing available in the Rust
standard library. The test currently fails and thus shows that the issue
is reproducible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfrimmel jfrimmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfrimmel