ParamChecks usage

[tracylynne99]

While doing a comparison between baselines 1.0.17 and FSE (as of 30-Jan-2014), I noticed that several classes in 1.0.17 are using ParamChecks.nullNotPermitted to do null-checking, but the corresponding classes in FSE are not. For example: CategoryMarker, AbstractOverlay, etc. I do see that ParamChecks is used in many places in FSE, though (DatasetUtilities, TimeSeries, etc)

What that tells me is that making changes to use ParamChecks in FSE is a work in progress - is that accurate?

If so, I volunteer to finish (or at least make more progress on!) making changes in FSE to use ParamChecks. :-> That is, if no one else is already working on it?

[jfree]

Yes, please go ahead. Before the last JFreeChart release I went through and updated most cases, but I didn't merge to JFreeChart-FSE because I didn't have time.

[tracylynne99]

Awesome, I will go ahead and do that.

Here's an unrelated question about the ChartPanel class: When comparing 1.0.17 with FSE, I noticed several items in the ChartPanel class marked with "@SInCE 1.0.14" (ie: availableLiveMouseHandlers, auxiliaryMouseHandlers, etc), but they are not present in the 1.0.17 baseline.

So I thought perhaps they had been removed, at some point, between JFreeChart 1.0.14 and 1.0.17, and that removal hadn't quite made it into the FSE baseline.

I downloaded the baselines for 1.0.12 through 1.0.16, did a search for those names, but found nothing.

So I'm guessing that "@SInCE 1.0.14" doesn't mean that it was part of JFreeChart 1.0.14...?

Thanks!
-Tracy
---- David Gilbert [email protected] wrote:

Yes, please go ahead. Before the last JFreeChart release I went through and updated most cases, but I didn't merge to JFreeChart-FSE because I didn't have time.

---

Reply to this email directly or view it on GitHub:
#27 (comment)

[jfree]

Please remove those version tags. The item selection code that is present in JFreeChart-FSE was first implemented against the 1.0.x codebase but I never committed it because it ended up needing too many API changes.

Best regards,

David

On Feb 26, 2014, at 6:08 PM, tracylynne99 wrote:

Awesome, I will go ahead and do that.

Here's an unrelated question about the ChartPanel class: When comparing 1.0.17 with FSE, I noticed several items in the ChartPanel class marked with "@SInCE 1.0.14" (ie: availableLiveMouseHandlers, auxiliaryMouseHandlers, etc), but they are not present in the 1.0.17 baseline.

So I thought perhaps they had been removed, at some point, between JFreeChart 1.0.14 and 1.0.17, and that removal hadn't quite made it into the FSE baseline.

I downloaded the baselines for 1.0.12 through 1.0.16, did a search for those names, but found nothing.

So I'm guessing that "@SInCE 1.0.14" doesn't mean that it was part of JFreeChart 1.0.14...?

Thanks!
-Tracy
---- David Gilbert [email protected] wrote:

Yes, please go ahead. Before the last JFreeChart release I went through and updated most cases, but I didn't merge to JFreeChart-FSE because I didn't have time.

---

Reply to this email directly or view it on GitHub:
#27 (comment)
—
Reply to this email directly or view it on GitHub.