Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scikit-learn compatibility for CleanTransformer + tests #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CarloLepelaars
Copy link

@CarloLepelaars CarloLepelaars commented Nov 23, 2022

First of all, thank you for building and open-sourcing this! It has been very helpful for us at @crowdcent.

We ran into some issues when trying to use CleanTransformer as a component. These are:

  1. fit should have y=None defined for compatbility so supervised training can be done where CleanTransformer is a component in a Pipeline.
  2. It is standard since scikit-learn==1.1 to define get_feature_names_out (Source).

I've implemented these and wrote some accompanying tests. Would be happy to discuss any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant