Improve scikit-learn compatibility for CleanTransformer
+ tests
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for building and open-sourcing this! It has been very helpful for us at @crowdcent.
We ran into some issues when trying to use
CleanTransformer
as a component. These are:fit
should havey=None
defined for compatbility so supervised training can be done whereCleanTransformer
is a component in aPipeline
.scikit-learn==1.1
to defineget_feature_names_out
(Source).I've implemented these and wrote some accompanying tests. Would be happy to discuss any changes.